-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Update *psd1 for every module to use relative path, fix tooling issue in tools/CheckAssemblies.ps1 #10228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…kAssemblies.ps1 to use the new paths
…kAssemblies.ps1 to use the new paths
…rly/azure-powershell into relative-paths-test#10072
…to relative-paths-test#10072
|
@VeryEarly, let's create a signed build based on your branch to test with for this. |
|
/azp run |
|
Pull request contains merge conflicts. |
| } | ||
|
|
||
| $LoadedAssemblies = $LoadedAssemblies | ForEach-Object { $_.Substring(2).Replace(".dll", "") } | ||
| $LoadedAssemblies = $LoadedAssemblies | ForEach-Object { $_.Replace(".dll", "") } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really the only place we have this dependencyt, nice.
markcowl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now let's come up with a plan with how we do validation, and we can target this PR for next release.
I'll fix the CI and run smoke test against this build. |
|
smoke test passed (except machine learning compute which was deprecated) |
|
why are there 77 psd1 changed but only 74 change log? |
add changelog.md for datafactory and kusto, maintenance was not released yet so should not have change log |
isra-fel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
Description
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added